Commit 54a8cd0f authored by Joe Hattori's avatar Joe Hattori Committed by Bjorn Andersson
Browse files

soc: qcom: ice: Remove the device_link field in qcom_ice 



The struct device_link *link field in struct qcom_ice is only used to
store the result of a device_link_add call with the
DL_FLAG_AUTOREMOVE_SUPPLIER flag. With this flag, the resulting value
can only be used to check whether the link is present or not, as per the
device_link_add description, hence this commit removes the field.

Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20241030025046.303342-1-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 98e5b7f9

drivers/soc/qcom/ice.c

+3 −3
Original line number Diff line number Diff line
@@ -44,7 +44,6 @@ 
struct qcom_ice {

	struct device *dev;

	void __iomem *base;

	struct device_link *link;



	struct clk *core_clk;

};
@@ -268,6 +267,7 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) 
	struct qcom_ice *ice;

	struct resource *res;

	void __iomem *base;

	struct device_link *link;



	if (!dev || !dev->of_node)

		return ERR_PTR(-ENODEV);
@@ -311,8 +311,8 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) 
		return ERR_PTR(-EPROBE_DEFER);

	}



	ice->link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER);

	if (!ice->link) {

	link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER);

	if (!link) {

		dev_err(&pdev->dev,

			"Failed to create device link to consumer %s\n",

			dev_name(dev));