Commit 55df7c0c authored by Dave Airlie's avatar Dave Airlie
Browse files

drm/ttm/xe: drop unused force_alloc flag 



This flag used to be used in the old memory tracking code, that
code got migrated into the vmwgfx driver[1], and then got removed
from the tree[2], but this piece got left behind.

[1] f07069da ("drm/ttm: move memory accounting into vmwgfx v4")
[2] 8aadeb8a ("drm/vmwgfx: Remove the dedicated memory accounting")

Cleanup the dead code.

Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent b6030177

drivers/gpu/drm/ttm/ttm_bo_vm.c

+0 −1
Original line number Diff line number Diff line
@@ -220,7 +220,6 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, 
		struct ttm_operation_ctx ctx = {

			.interruptible = true,

			.no_wait_gpu = false,

			.force_alloc = true

		};



		ttm = bo->ttm;

drivers/gpu/drm/ttm/ttm_resource.c

+0 −1
Original line number Diff line number Diff line
@@ -548,7 +548,6 @@ int ttm_resource_manager_evict_all(struct ttm_device *bdev, 
	struct ttm_operation_ctx ctx = {

		.interruptible = false,

		.no_wait_gpu = false,

		.force_alloc = true

	};

	struct dma_fence *fence;

	int ret;

drivers/gpu/drm/xe/xe_bo.c

+1 −3
Original line number Diff line number Diff line
@@ -2759,19 +2759,17 @@ int xe_bo_migrate(struct xe_bo *bo, u32 mem_type) 
/**

 * xe_bo_evict - Evict an object to evict placement

 * @bo: The buffer object to migrate.

 * @force_alloc: Set force_alloc in ttm_operation_ctx

 *

 * On successful completion, the object memory will be moved to evict

 * placement. This function blocks until the object has been fully moved.

 *

 * Return: 0 on success. Negative error code on failure.

 */

int xe_bo_evict(struct xe_bo *bo, bool force_alloc)

int xe_bo_evict(struct xe_bo *bo)

{

	struct ttm_operation_ctx ctx = {

		.interruptible = false,

		.no_wait_gpu = false,

		.force_alloc = force_alloc,

		.gfp_retry_mayfail = true,

	};

	struct ttm_placement placement;

drivers/gpu/drm/xe/xe_bo.h

+1 −1
Original line number Diff line number Diff line
@@ -271,7 +271,7 @@ uint64_t vram_region_gpu_offset(struct ttm_resource *res); 
bool xe_bo_can_migrate(struct xe_bo *bo, u32 mem_type);



int xe_bo_migrate(struct xe_bo *bo, u32 mem_type);

int xe_bo_evict(struct xe_bo *bo, bool force_alloc);

int xe_bo_evict(struct xe_bo *bo);



int xe_bo_evict_pinned(struct xe_bo *bo);

int xe_bo_restore_pinned(struct xe_bo *bo);

drivers/gpu/drm/xe/xe_dma_buf.c

+1 −1
Original line number Diff line number Diff line
@@ -236,7 +236,7 @@ static void xe_dma_buf_move_notify(struct dma_buf_attachment *attach) 
	struct drm_gem_object *obj = attach->importer_priv;

	struct xe_bo *bo = gem_to_xe_bo(obj);



	XE_WARN_ON(xe_bo_evict(bo, false));

	XE_WARN_ON(xe_bo_evict(bo));

}



static const struct dma_buf_attach_ops xe_dma_buf_attach_ops = {