Commit 5648de0b authored by Jiri Pirko's avatar Jiri Pirko Committed by Paolo Abeni
Browse files

devlink: introduce a helper for netlink multicast send 



Introduce a helper devlink_nl_notify_send() so each object notification
function does not have to call genlmsg_multicast_netns() with the same
arguments.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent cddbff47

net/devlink/dev.c

+2 −4
Original line number Diff line number Diff line
@@ -217,8 +217,7 @@ static void devlink_notify(struct devlink *devlink, enum devlink_command cmd) 
		return;

	}



	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),

				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);

	devlink_nl_notify_send(devlink, msg);

}



int devlink_nl_get_doit(struct sk_buff *skb, struct genl_info *info)
@@ -1013,8 +1012,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink, 
	if (err)

		goto out_free_msg;



	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),

				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);

	devlink_nl_notify_send(devlink, msg);

	return;



out_free_msg:

net/devlink/devl_internal.h

+7 −0
Original line number Diff line number Diff line
@@ -191,6 +191,13 @@ static inline bool devlink_nl_notify_need(struct devlink *devlink) 
				  DEVLINK_MCGRP_CONFIG);

}



static inline void devlink_nl_notify_send(struct devlink *devlink,

					  struct sk_buff *msg)

{

	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),

				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);

}



/* Notify */

void devlink_notify_register(struct devlink *devlink);

void devlink_notify_unregister(struct devlink *devlink);

net/devlink/health.c

+1 −2
Original line number Diff line number Diff line
@@ -509,8 +509,7 @@ static void devlink_recover_notify(struct devlink_health_reporter *reporter, 
		return;

	}



	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,

				0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);

	devlink_nl_notify_send(devlink, msg);

}



void

net/devlink/linecard.c

+1 −2
Original line number Diff line number Diff line
@@ -150,8 +150,7 @@ static void devlink_linecard_notify(struct devlink_linecard *linecard, 
		return;

	}



	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),

				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);

	devlink_nl_notify_send(devlink, msg);

}



void devlink_linecards_notify_register(struct devlink *devlink)

net/devlink/param.c

+1 −2
Original line number Diff line number Diff line
@@ -356,8 +356,7 @@ static void devlink_param_notify(struct devlink *devlink, 
		return;

	}



	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),

				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);

	devlink_nl_notify_send(devlink, msg);

}



static void devlink_params_notify(struct devlink *devlink,