Commit 5712e323 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: net-drv: stats: sanity check netlink dumps 



Sanity check netlink dumps, to make sure dumps don't have
repeated entries or gaps in IDs.

Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/20241213152244.3080955-6-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1234810b

tools/testing/selftests/drivers/net/stats.py

+18 −1
Original line number Diff line number Diff line
@@ -110,6 +110,23 @@ def qstat_by_ifindex(cfg) -> None: 
            ksft_ge(triple[1][key], triple[0][key], comment="bad key: " + key)

            ksft_ge(triple[2][key], triple[1][key], comment="bad key: " + key)



    # Sanity check the dumps

    queues = NetdevFamily(recv_size=4096).qstats_get({"scope": "queue"}, dump=True)

    # Reformat the output into {ifindex: {rx: [id, id, ...], tx: [id, id, ...]}}

    parsed = {}

    for entry in queues:

        ifindex = entry["ifindex"]

        if ifindex not in parsed:

            parsed[ifindex] = {"rx":[], "tx": []}

        parsed[ifindex][entry["queue-type"]].append(entry['queue-id'])

    # Now, validate

    for ifindex, queues in parsed.items():

        for qtype in ['rx', 'tx']:

            ksft_eq(len(queues[qtype]), len(set(queues[qtype])),

                    comment="repeated queue keys")

            ksft_eq(len(queues[qtype]), max(queues[qtype]) + 1,

                    comment="missing queue keys")



    # Test invalid dumps

    # 0 is invalid

    with ksft_raises(NlError) as cm:
@@ -158,7 +175,7 @@ def check_down(cfg) -> None: 




def main() -> None:

    with NetDrvEnv(__file__) as cfg:

    with NetDrvEnv(__file__, queue_count=100) as cfg:

        ksft_run([check_pause, check_fec, pkt_byte_sum, qstat_by_ifindex,

                  check_down],

                 args=(cfg, ))