Unverified Commit 59c5dbd5 authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: SDCA: Shrink detected_mode_handler() stack frame 



The stack frame for detected_mode_handler() is a bit large. Dynamically
allocate the control value struct, which is most of the size, to avoid
this.

Fixes: b9ab3b61 ("ASoC: SDCA: Add some initial IRQ handlers")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507182222.OLgOy9fX-lkp@intel.com/


Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20250722102305.2513755-1-ckeepax@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5b838a24

sound/soc/sdca/sdca_interrupts.c

+7 −3
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ static irqreturn_t detected_mode_handler(int irq, void *data) 
	struct snd_soc_card *card = component->card;

	struct rw_semaphore *rwsem = &card->snd_card->controls_rwsem;

	struct snd_kcontrol *kctl = interrupt->priv;

	struct snd_ctl_elem_value ucontrol;

	struct snd_ctl_elem_value *ucontrol __free(kfree) = NULL;

	struct soc_enum *soc_enum;

	unsigned int reg, val;

	int ret;
@@ -204,10 +204,14 @@ static irqreturn_t detected_mode_handler(int irq, void *data) 


	dev_dbg(dev, "%s: %#x\n", interrupt->name, val);



	ucontrol.value.enumerated.item[0] = snd_soc_enum_val_to_item(soc_enum, val);

	ucontrol = kzalloc(sizeof(*ucontrol), GFP_KERNEL);

	if (!ucontrol)

		return IRQ_NONE;



	ucontrol->value.enumerated.item[0] = snd_soc_enum_val_to_item(soc_enum, val);



	down_write(rwsem);

	ret = kctl->put(kctl, &ucontrol);

	ret = kctl->put(kctl, ucontrol);

	up_write(rwsem);

	if (ret < 0) {

		dev_err(dev, "failed to update selected mode: %d\n", ret);