Commit 5c1de379 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (w83627ehf) Fix underflows seen when writing limit attributes 



DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large
negative number such as -9223372036854775808 is provided by the user.
Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 0403e10b

drivers/hwmon/w83627ehf.c

+2 −2
Original line number Diff line number Diff line
@@ -895,7 +895,7 @@ store_target_temp(struct device *dev, struct device_attribute *attr, 
	if (err < 0)

		return err;



	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, 127);

	val = DIV_ROUND_CLOSEST(clamp_val(val, 0, 127000), 1000);



	mutex_lock(&data->update_lock);

	data->target_temp[nr] = val;
@@ -920,7 +920,7 @@ store_tolerance(struct device *dev, struct device_attribute *attr, 
		return err;



	/* Limit the temp to 0C - 15C */

	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, 15);

	val = DIV_ROUND_CLOSEST(clamp_val(val, 0, 15000), 1000);



	mutex_lock(&data->update_lock);

	reg = w83627ehf_read_value(data, W83627EHF_REG_TOLERANCE[nr]);