Commit 5ebdc6be authored by Zijun Hu's avatar Zijun Hu Committed by Vinod Koul
Browse files

phy: core: Fix an OF node refcount leakage in _of_phy_get() 



_of_phy_get() will directly return when suffers of_device_is_compatible()
error, but it forgets to decrease refcount of OF node @args.np before error
return, the refcount was increased by previous of_parse_phandle_with_args()
so causes the OF node's refcount leakage.

Fix by decreasing the refcount via of_node_put() before the error return.

Fixes: b7563e27 ("phy: work around 'phys' references to usb-nop-xceiv devices")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-4-40ae28f5015a@quicinc.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 4dc48c88

drivers/phy/phy-core.c

+5 −2
Original line number Diff line number Diff line
@@ -629,8 +629,10 @@ static struct phy *_of_phy_get(struct device_node *np, int index) 
		return ERR_PTR(-ENODEV);



	/* This phy type handled by the usb-phy subsystem for now */

	if (of_device_is_compatible(args.np, "usb-nop-xceiv"))

		return ERR_PTR(-ENODEV);

	if (of_device_is_compatible(args.np, "usb-nop-xceiv")) {

		phy = ERR_PTR(-ENODEV);

		goto out_put_node;

	}



	mutex_lock(&phy_provider_mutex);

	phy_provider = of_phy_provider_lookup(args.np);
@@ -652,6 +654,7 @@ static struct phy *_of_phy_get(struct device_node *np, int index) 


out_unlock:

	mutex_unlock(&phy_provider_mutex);

out_put_node:

	of_node_put(args.np);



	return phy;