Commit 5ed4b6b3 authored by zhouwenhao's avatar zhouwenhao Committed by Andrew Morton
Browse files

objpool: fix the overestimation of object pooling metadata size 

objpool uses struct objpool_head to store metadata information, and its
cpu_slots member points to an array of pointers that store the addresses
of the percpu ring arrays.  However, the memory size allocated during the
initialization of cpu_slots is nr_cpu_ids * sizeof(struct objpool_slot). 
On a 64-bit machine, the size of struct objpool_slot is 16 bytes, which is
twice the size of the actual pointer required, and the extra memory is
never be used, resulting in a waste of memory.  Therefore, the memory size
required for cpu_slots needs to be corrected.

Link: https://lkml.kernel.org/r/20260202132846.68257-1-zhouwenhao7600@gmail.com


Fixes: b4edb8d2 ("lib: objpool added: ring-array based lockless MPMC")
Signed-off-by: default avatarzhouwenhao <zhouwenhao7600@gmail.com>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Matt Wu <wuqiang.matt@bytedance.com>
Cc: wuqiang.matt <wuqiang.matt@bytedance.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent b2433552

lib/objpool.c

+1 −1
Original line number Diff line number Diff line
@@ -142,7 +142,7 @@ int objpool_init(struct objpool_head *pool, int nr_objs, int object_size, 
	pool->gfp = gfp & ~__GFP_ZERO;

	pool->context = context;

	pool->release = release;

	slot_size = nr_cpu_ids * sizeof(struct objpool_slot);

	slot_size = nr_cpu_ids * sizeof(struct objpool_slot *);

	pool->cpu_slots = kzalloc(slot_size, pool->gfp);

	if (!pool->cpu_slots)

		return -ENOMEM;