Unverified Commit 5ff1fbb3 authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

platform/x86: think-lmi: Fix class device unregistration 



Devices under the firmware_attributes_class do not have unique a dev_t.
Therefore, device_unregister() should be used instead of
device_destroy(), since the latter may match any device with a given
dev_t.

Fixes: a40cd7ef ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250625-dest-fix-v1-2-3a0f342312bb@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 11cba479

drivers/platform/x86/think-lmi.c

+2 −2
Original line number Diff line number Diff line
@@ -1554,7 +1554,7 @@ static int tlmi_sysfs_init(void) 
fail_create_attr:

	tlmi_release_attr();

fail_device_created:

	device_destroy(&firmware_attributes_class, MKDEV(0, 0));

	device_unregister(tlmi_priv.class_dev);

fail_class_created:

	return ret;

}
@@ -1781,7 +1781,7 @@ static int tlmi_analyze(struct wmi_device *wdev) 
static void tlmi_remove(struct wmi_device *wdev)

{

	tlmi_release_attr();

	device_destroy(&firmware_attributes_class, MKDEV(0, 0));

	device_unregister(tlmi_priv.class_dev);

}



static int tlmi_probe(struct wmi_device *wdev, const void *context)