Commit 604c7589 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

usb: typec: tps6598x: Fix return value check in tps6598x_probe() 



In case of error, the function device_get_named_child_node() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: 18a6c866 ("usb: typec: tps6598x: Add USB role switching logic")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210308094841.3587751-1-weiyongjun1@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 493d0856

drivers/usb/typec/tps6598x.c

+2 −2
Original line number Diff line number Diff line
@@ -629,8 +629,8 @@ static int tps6598x_probe(struct i2c_client *client) 
		return ret;



	fwnode = device_get_named_child_node(&client->dev, "connector");

	if (IS_ERR(fwnode))

		return PTR_ERR(fwnode);

	if (!fwnode)

		return -ENODEV;



	tps->role_sw = fwnode_usb_role_switch_get(fwnode);

	if (IS_ERR(tps->role_sw)) {