Commit 6098dcfa authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/display: hide global state iterators, remove unused 



for_each_{new,old,oldnew}_global_obj_in_state() are only used within
intel_global_state.c, hide them there. intel_for_each_global_obj() is
unused, remove it.

Reviewed-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/a23212d9298423d8971d6ad62f961386f7f927cc.1753953530.git.jani.nikula@intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent cdaecac4

drivers/gpu/drm/i915/display/intel_global_state.c

+25 −0
Original line number Diff line number Diff line
@@ -13,6 +13,31 @@ 
#include "intel_display_types.h"

#include "intel_global_state.h"



#define for_each_new_global_obj_in_state(__state, obj, new_obj_state, __i) \

	for ((__i) = 0; \

	     (__i) < (__state)->num_global_objs && \

		     ((obj) = (__state)->global_objs[__i].ptr, \

		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \

	     (__i)++) \

		for_each_if(obj)



#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \

	for ((__i) = 0; \

	     (__i) < (__state)->num_global_objs && \

		     ((obj) = (__state)->global_objs[__i].ptr, \

		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \

	     (__i)++) \

		for_each_if(obj)



#define for_each_oldnew_global_obj_in_state(__state, obj, old_obj_state, new_obj_state, __i) \

	for ((__i) = 0; \

	     (__i) < (__state)->num_global_objs && \

		     ((obj) = (__state)->global_objs[__i].ptr, \

		      (old_obj_state) = (__state)->global_objs[__i].old_state, \

		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \

	     (__i)++) \

		for_each_if(obj)



struct intel_global_commit {

	struct kref ref;

	struct completion done;

drivers/gpu/drm/i915/display/intel_global_state.h

+0 −28
Original line number Diff line number Diff line
@@ -26,34 +26,6 @@ struct intel_global_obj { 
	const struct intel_global_state_funcs *funcs;

};



#define intel_for_each_global_obj(obj, dev_priv) \

	list_for_each_entry(obj, &(dev_priv)->display.global.obj_list, head)



#define for_each_new_global_obj_in_state(__state, obj, new_obj_state, __i) \

	for ((__i) = 0; \

	     (__i) < (__state)->num_global_objs && \

		     ((obj) = (__state)->global_objs[__i].ptr, \

		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \

	     (__i)++) \

		for_each_if(obj)



#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \

	for ((__i) = 0; \

	     (__i) < (__state)->num_global_objs && \

		     ((obj) = (__state)->global_objs[__i].ptr, \

		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \

	     (__i)++) \

		for_each_if(obj)



#define for_each_oldnew_global_obj_in_state(__state, obj, old_obj_state, new_obj_state, __i) \

	for ((__i) = 0; \

	     (__i) < (__state)->num_global_objs && \

		     ((obj) = (__state)->global_objs[__i].ptr, \

		      (old_obj_state) = (__state)->global_objs[__i].old_state, \

		      (new_obj_state) = (__state)->global_objs[__i].new_state, 1); \

	     (__i)++) \

		for_each_if(obj)



struct intel_global_commit;



struct intel_global_state {