Commit 60c5f158 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/eventfd: move actual signaling part into separate helper 

In preparation for using this from multiple spots, move the signaling
into a helper.

Link: https://lore.kernel.org/r/20240921080307.185186-4-axboe@kernel.dk


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 3c90b80d

io_uring/eventfd.c

+18 −10
Original line number Diff line number Diff line
@@ -47,6 +47,22 @@ static void io_eventfd_put(struct io_ev_fd *ev_fd) 
		call_rcu(&ev_fd->rcu, io_eventfd_free);

}



/*

 * Returns true if the caller should put the ev_fd reference, false if not.

 */

static bool __io_eventfd_signal(struct io_ev_fd *ev_fd)

{

	if (eventfd_signal_allowed()) {

		eventfd_signal_mask(ev_fd->cq_ev_fd, EPOLL_URING_WAKE);

		return true;

	}

	if (!atomic_fetch_or(BIT(IO_EVENTFD_OP_SIGNAL_BIT), &ev_fd->ops)) {

		call_rcu_hurry(&ev_fd->rcu, io_eventfd_do_signal);

		return false;

	}

	return true;

}



void io_eventfd_signal(struct io_ring_ctx *ctx)

{

	struct io_ev_fd *ev_fd = NULL;
@@ -73,15 +89,7 @@ void io_eventfd_signal(struct io_ring_ctx *ctx) 
		return;

	if (!refcount_inc_not_zero(&ev_fd->refs))

		return;



	if (likely(eventfd_signal_allowed())) {

		eventfd_signal_mask(ev_fd->cq_ev_fd, EPOLL_URING_WAKE);

	} else {

		if (!atomic_fetch_or(BIT(IO_EVENTFD_OP_SIGNAL_BIT), &ev_fd->ops)) {

			call_rcu_hurry(&ev_fd->rcu, io_eventfd_do_signal);

			return;

		}

	}

	if (__io_eventfd_signal(ev_fd))

		io_eventfd_put(ev_fd);

}