Commit 60e8ffaf authored by Gaghik Khachatrian's avatar Gaghik Khachatrian Committed by Alex Deucher
Browse files

drm/amd/display: Fix Silence warnings 



Also affects: freesync, hdcp, info_packet, power

[Why] Resolve compiler warnings by marking unused parameters explicitly.

[How] In .c/.h keep parameter names in signatures and add a line with
      `(void)param;`  inside the function body

Preserved function signatures and avoids breaking code paths that
may reference the parameter under conditional compilation.

Reviewed-by: default avatarAric Cyr <aric.cyr@amd.com>
Signed-off-by: default avatarGaghik Khachatrian <gaghik.khachatrian@amd.com>
Signed-off-by: default avatarChuanyu Tseng <chuanyu.tseng@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a3c7ab16

drivers/gpu/drm/amd/display/modules/color/color_gamma.c

+2 −0
Original line number Diff line number Diff line
@@ -896,6 +896,7 @@ static void build_de_pq(struct pwl_float_data_ex *de_pq, 
		uint32_t hw_points_num,

		const struct hw_x_point *coordinate_x)

{

	(void)coordinate_x;

	uint32_t i;

	struct fixed31_32 output;

	struct fixed31_32 *de_pq_table = mod_color_get_table(type_de_pq_table);
@@ -1339,6 +1340,7 @@ static void scale_gamma_dx(struct pwl_float_data *pwl_rgb, 
		const struct dc_gamma *ramp,

		struct dividers dividers)

{

	(void)dividers;

	uint32_t i;

	struct fixed31_32 min = dc_fixpt_zero;

	struct fixed31_32 max = dc_fixpt_one;

drivers/gpu/drm/amd/display/modules/freesync/freesync.c

+6 −0
Original line number Diff line number Diff line
@@ -114,6 +114,7 @@ static unsigned int calc_duration_in_us_from_v_total( 
		const struct mod_vrr_params *in_vrr,

		unsigned int v_total)

{

	(void)in_vrr;

	unsigned int duration_in_us =

			(unsigned int)(div64_u64(((unsigned long long)(v_total)

				* 10000) * stream->timing.h_total,
@@ -218,6 +219,7 @@ static void update_v_total_for_static_ramp( 
		const struct dc_stream_state *stream,

		struct mod_vrr_params *in_out_vrr)

{

	(void)core_freesync;

	unsigned int v_total = 0;

	unsigned int current_duration_in_us =

			calc_duration_in_us_from_v_total(
@@ -292,6 +294,7 @@ static void apply_below_the_range(struct core_freesync *core_freesync, 
		unsigned int last_render_time_in_us,

		struct mod_vrr_params *in_out_vrr)

{

	(void)core_freesync;

	unsigned int inserted_frame_duration_in_us = 0;

	unsigned int mid_point_frames_ceil = 0;

	unsigned int mid_point_frames_floor = 0;
@@ -447,6 +450,7 @@ static void apply_fixed_refresh(struct core_freesync *core_freesync, 
		unsigned int last_render_time_in_us,

		struct mod_vrr_params *in_out_vrr)

{

	(void)core_freesync;

	bool update = false;

	unsigned int max_render_time_in_us = in_out_vrr->max_duration_in_us;
@@ -545,6 +549,7 @@ static bool vrr_settings_require_update(struct core_freesync *core_freesync, 
		unsigned int max_refresh_in_uhz,

		struct mod_vrr_params *in_vrr)

{

	(void)core_freesync;

	if (in_vrr->state != in_config->state) {

		return true;

	} else if (in_vrr->state == VRR_STATE_ACTIVE_FIXED &&
@@ -946,6 +951,7 @@ void mod_freesync_build_vrr_infopacket(struct mod_freesync *mod_freesync, 
		struct dc_info_packet *infopacket,

		bool pack_sdp_v1_3)

{

	(void)mod_freesync;

	/* SPD info packet for FreeSync

	 * VTEM info packet for HdmiVRR

	 * Check if Freesync is supported. Return if false. If true,

drivers/gpu/drm/amd/display/modules/hdcp/hdcp.h

+1 −0
Original line number Diff line number Diff line
@@ -501,6 +501,7 @@ static inline void callback_in_ms(uint16_t time, struct mod_hdcp_output *output) 
static inline void set_watchdog_in_ms(struct mod_hdcp *hdcp, uint16_t time,

		struct mod_hdcp_output *output)

{

	(void)hdcp;

	output->watchdog_timer_needed = 1;

	output->watchdog_timer_delay = time;

}