Commit 61997271 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Jakub Kicinski
Browse files

net: usb: asix: ax88772: Increase phy_name size 



GCC compiler (Debian 14.2.0-17) is not happy about printing
into a too short buffer (when build with `make W=1`):

 drivers/net/usb/ax88172a.c:311:9: note: ‘snprintf’ output between 4 and 66 bytes into a destination of size 20

Indeed, the buffer size is chosen based on some assumptions,
while in general the assigned name might not fit. Increase
the buffer size to cover the minimum required one. With that,
change snprintf() to use sizeof() instead of the hard coded
value.

While at it, make sure that the PHY address is not bigger than
the allowed maximum.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250324144751.1271761-3-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2c5ac026

drivers/net/usb/ax88172a.c

+8 −4
Original line number Diff line number Diff line
@@ -18,8 +18,8 @@ 
struct ax88172a_private {

	struct mii_bus *mdio;

	struct phy_device *phydev;

	char phy_name[20];

	u16 phy_addr;

	char phy_name[PHY_ID_SIZE];

	u8 phy_addr;

	u16 oldmode;

	int use_embdphy;

	struct asix_rx_fixup_info rx_fixup_info;
@@ -210,7 +210,11 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf) 
	ret = asix_read_phy_addr(dev, priv->use_embdphy);

	if (ret < 0)

		goto free;



	if (ret >= PHY_MAX_ADDR) {

		netdev_err(dev->net, "Invalid PHY address %#x\n", ret);

		ret = -ENODEV;

		goto free;

	}

	priv->phy_addr = ret;



	ax88172a_reset_phy(dev, priv->use_embdphy);
@@ -308,7 +312,7 @@ static int ax88172a_reset(struct usbnet *dev) 
		   rx_ctl);



	/* Connect to PHY */

	snprintf(priv->phy_name, 20, PHY_ID_FMT,

	snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT,

		 priv->mdio->id, priv->phy_addr);



	priv->phydev = phy_connect(dev->net, priv->phy_name,