Commit 66a0a2b0 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: sh: Fix wrong argument order for copy_from_iter() 



Fix a brown paper bag bug I introduced at converting to the standard
iter helper; the arguments were wrongly passed and have to be
swapped.

Fixes: 9b5f8ee4 ("ALSA: sh: Use standard helper for buffer accesses")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412140019.jat5Dofr-lkp@intel.com/
Link: https://patch.msgid.link/20241220114417.5898-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 55853cb8

sound/sh/sh_dac_audio.c

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ static int snd_sh_dac_pcm_copy(struct snd_pcm_substream *substream, 
	/* channel is not used (interleaved data) */

	struct snd_sh_dac *chip = snd_pcm_substream_chip(substream);



	if (copy_from_iter(chip->data_buffer + pos, src, count) != count)

	if (copy_from_iter(chip->data_buffer + pos, count, src) != count)

		return -EFAULT;

	chip->buffer_end = chip->data_buffer + pos + count;