Commit 66b06523 authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Stephen Boyd
Browse files

clk: Use of_property_present() 



Use of_property_present() to test for property presence rather than
of_(find|get)_property(). This is part of a larger effort to remove
callers of of_find_property() and similar functions.
of_(find|get)_property() leak the DT struct property and data pointers
which is a problem for dynamically allocated nodes which may be freed.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-4-robh@kernel.org


Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> # clk-mstp.c
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 9d6a5304

drivers/clk/clk.c

+1 −1
Original line number Diff line number Diff line
@@ -5232,7 +5232,7 @@ static int of_parse_clkspec(const struct device_node *np, int index, 
		 * clocks.

		 */

		np = np->parent;

		if (np && !of_get_property(np, "clock-ranges", NULL))

		if (np && !of_property_present(np, "clock-ranges"))

			break;

		index = 0;

	}

drivers/clk/renesas/clk-mstp.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static void __init cpg_mstp_clocks_init(struct device_node *np) 
	for (i = 0; i < MSTP_MAX_CLOCKS; ++i)

		clks[i] = ERR_PTR(-ENOENT);



	if (of_find_property(np, "clock-indices", &i))

	if (of_property_present(np, "clock-indices"))

		idxname = "clock-indices";

	else

		idxname = "renesas,clock-indices";

drivers/clk/versatile/clk-sp810.c

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ static void __init clk_sp810_of_setup(struct device_node *node) 
	init.parent_names = parent_names;

	init.num_parents = num;



	deprecated = !of_find_property(node, "assigned-clock-parents", NULL);

	deprecated = !of_property_present(node, "assigned-clock-parents");



	for (i = 0; i < ARRAY_SIZE(sp810->timerclken); i++) {

		snprintf(name, sizeof(name), "sp810_%d_%d", instance, i);