Commit 6810fad9 authored by Ye Bin's avatar Ye Bin Committed by Theodore Ts'o
Browse files

ext4: fix ext4_error_err save negative errno into superblock 



Fix As write_mmp_block() so that it returns -EIO instead of 1, so that
the correct error gets saved into the superblock.

Cc: stable@kernel.org
Fixes: 54d3adbc ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
Reported-by: default avatarLiu Zhi Qiang <liuzhiqiang26@huawei.com>
Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20210406025331.148343-1-yebin10@huawei.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent f88f1466

fs/ext4/mmp.c

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh) 
	wait_on_buffer(bh);

	sb_end_write(sb);

	if (unlikely(!buffer_uptodate(bh)))

		return 1;

		return -EIO;



	return 0;

}