Commit 699e7b85 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

sysfs: treewide: constify attribute callback of bin_attribute::llseek() 



The llseek() callbacks should not modify the struct
bin_attribute passed as argument.
Enforce this by marking the argument as const.

As there are not many callback implementers perform this change
throughout the tree at once.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Acked-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Link: https://lore.kernel.org/r/20241103-sysfs-const-bin_attr-v2-7-71110628844c@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 94a20fb9

drivers/pci/pci-sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -841,7 +841,7 @@ static const struct attribute_group pci_dev_config_attr_group = { 
static __maybe_unused loff_t

pci_llseek_resource(struct file *filep,

		    struct kobject *kobj __always_unused,

		    struct bin_attribute *attr,

		    const struct bin_attribute *attr,

		    loff_t offset, int whence)

{

	return fixed_size_llseek(filep, offset, whence, attr->size);

include/linux/sysfs.h

+1 −1
Original line number Diff line number Diff line
@@ -307,7 +307,7 @@ struct bin_attribute { 
			char *, loff_t, size_t);

	ssize_t (*write)(struct file *, struct kobject *, struct bin_attribute *,

			 char *, loff_t, size_t);

	loff_t (*llseek)(struct file *, struct kobject *, struct bin_attribute *,

	loff_t (*llseek)(struct file *, struct kobject *, const struct bin_attribute *,

			 loff_t, int);

	int (*mmap)(struct file *, struct kobject *, const struct bin_attribute *attr,

		    struct vm_area_struct *vma);