Commit 6cfba115 authored Jan 06, 2025 by Karan Tilak Kumar Committed by Martin K. Petersen Jan 10, 2025

scsi: fnic: Remove extern definition from .c files



Implement review comments from Martin:
    Remove extern definition of fnic_fip_queue from .c files

Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250106224451.3597-2-kartilak@cisco.com


Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 5b6179d4

drivers/scsi/fnic/fip.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -7,8 +7,6 @@
		#include "fip.h"
		#include <linux/etherdevice.h>

		extern struct workqueue_struct *fnic_fip_queue;

		#define FIP_FNIC_RESET_WAIT_COUNT 15

		/**

drivers/scsi/fnic/fip.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -131,6 +131,8 @@ void fnic_fcoe_start_flogi(struct fnic *fnic);
		void fnic_fcoe_process_cvl(struct fnic fnic, struct fip_header fiph);
		void fnic_vlan_discovery_timeout(struct fnic *fnic);

		extern struct workqueue_struct *fnic_fip_queue;

		#ifdef FNIC_DEBUG
		static inline void
		fnic_debug_dump_fip_frame(struct fnic fnic, struct ethhdr eth,

drivers/scsi/fnic/fnic_fcs.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -27,7 +27,6 @@

		#define MAX_RESET_WAIT_COUNT 64

		extern struct workqueue_struct *fnic_fip_queue;
		struct workqueue_struct *fnic_event_queue;

		static uint8_t FCOE_ALL_FCF_MAC[6] = FC_FCOE_FLOGI_MAC;