Commit 72310650 authored by Biju Das's avatar Biju Das Committed by Thomas Gleixner
Browse files

irqchip/renesas-rzv2h: Fix wrong variable usage in rzv2h_tint_set_type() 



The variable tssel_n is used for selecting TINT source and titsel_n for
setting the interrupt type. The variable titsel_n is wrongly used for
enabling the TINT interrupt in rzv2h_tint_set_type(). Fix this issue by
using the correct variable tssel_n.

While at it, move the tien variable assignment near to tssr.

Fixes: 0d7605e7 ("irqchip: Add RZ/V2H(P) Interrupt Control Unit (ICU) driver")
Reported-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20250224131253.134199-3-biju.das.jz@bp.renesas.com
Closes: https://lore.kernel.org/CAMuHMdU3xJpz-jh=j7t4JreBat2of2ksP_OR3+nKAoZBr4pSxg@mail.gmail.com
parent 9d245214

drivers/irqchip/irq-renesas-rzv2h.c

+1 −1
Original line number Diff line number Diff line
@@ -301,10 +301,10 @@ static int rzv2h_tint_set_type(struct irq_data *d, unsigned int type) 


	tssr_k = ICU_TSSR_K(tint_nr);

	tssel_n = ICU_TSSR_TSSEL_N(tint_nr);

	tien = ICU_TSSR_TIEN(tssel_n);



	titsr_k = ICU_TITSR_K(tint_nr);

	titsel_n = ICU_TITSR_TITSEL_N(tint_nr);

	tien = ICU_TSSR_TIEN(titsel_n);



	guard(raw_spinlock)(&priv->lock);