Commit 723c1dd3 authored by Pierre-Eric Pelloux-Prayer's avatar Pierre-Eric Pelloux-Prayer Committed by Alex Deucher
Browse files

drm/amdgpu: clear job on failure in amdgpu_job_alloc(_with_ib) 



If memory is freed we need to nullify the pointer or the caller
might call kfree again (eg: amdgpu_cs_parser_fini calls kfree on
all non-null job pointers).

Fixes: db36632e ("drm/amdgpu: clean up and unify hw fence handling")
Signed-off-by: default avatarPierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5de8ce0f

drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

+2 −0
Original line number Diff line number Diff line
@@ -224,6 +224,7 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, struct amdgpu_vm *vm, 
	kfree((*job)->hw_fence);

err_job:

	kfree(*job);

	*job = NULL;



	return r;

}
@@ -246,6 +247,7 @@ int amdgpu_job_alloc_with_ib(struct amdgpu_device *adev, 
		if (entity)

			drm_sched_job_cleanup(&(*job)->base);

		kfree(*job);

		*job = NULL;

	}



	return r;