Commit 72be72be authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

mpls: Use nlmsg_payload in mpls_valid_fib_dump_req 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250414-nlmsg-v2-5-3d90cb42c6af@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 77d02290

net/mpls/af_mpls.c

+2 −2
Original line number Diff line number Diff line
@@ -2095,12 +2095,12 @@ static int mpls_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh, 
	struct rtmsg *rtm;

	int err, i;



	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*rtm))) {

	rtm = nlmsg_payload(nlh, sizeof(*rtm));

	if (!rtm) {

		NL_SET_ERR_MSG_MOD(extack, "Invalid header for FIB dump request");

		return -EINVAL;

	}



	rtm = nlmsg_data(nlh);

	if (rtm->rtm_dst_len || rtm->rtm_src_len  || rtm->rtm_tos   ||

	    rtm->rtm_table   || rtm->rtm_scope    || rtm->rtm_type  ||

	    rtm->rtm_flags) {