Commit 72f51a4f authored by Eric Biggers's avatar Eric Biggers
Browse files

loongarch/crc32: expose CRC32 functions through lib 



Move the loongarch CRC32 assembly code into the lib directory and wire
it up to the library interface.  This allows it to be used without going
through the crypto API.  It remains usable via the crypto API too via
the shash algorithms that use the library interface.  Thus all the
arch-specific "shash" code becomes unnecessary and is removed.

Note: to see the diff from arch/loongarch/crypto/crc32-loongarch.c to
arch/loongarch/lib/crc32-loongarch.c, view this commit with
'git show -M10'.

Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
Reviewed-by: default avatarWangYuli <wangyuli@uniontech.com>
Link: https://lore.kernel.org/r/20241202010844.144356-7-ebiggers@kernel.org


Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
parent 1e1b6dbc

arch/loongarch/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ config LOONGARCH 
	select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE

	select ARCH_HAS_ACPI_TABLE_UPGRADE	if ACPI

	select ARCH_HAS_CPU_FINALIZE_INIT

	select ARCH_HAS_CRC32

	select ARCH_HAS_CURRENT_STACK_POINTER

	select ARCH_HAS_DEBUG_VM_PGTABLE

	select ARCH_HAS_FAST_MULTIPLIER

arch/loongarch/configs/loongson3_defconfig

+0 −1
Original line number Diff line number Diff line
@@ -1040,7 +1040,6 @@ CONFIG_CRYPTO_USER_API_HASH=m 
CONFIG_CRYPTO_USER_API_SKCIPHER=m

CONFIG_CRYPTO_USER_API_RNG=m

CONFIG_CRYPTO_USER_API_AEAD=m

CONFIG_CRYPTO_CRC32_LOONGARCH=m

CONFIG_CRYPTO_DEV_VIRTIO=m

CONFIG_DMA_CMA=y

CONFIG_DMA_NUMA_CMA=y

arch/loongarch/crypto/Kconfig

+0 −9
Original line number Diff line number Diff line
@@ -2,13 +2,4 @@ 


menu "Accelerated Cryptographic Algorithms for CPU (loongarch)"



config CRYPTO_CRC32_LOONGARCH

	tristate "CRC32c and CRC32"

	select CRC32

	select CRYPTO_HASH

	help

	  CRC32c and CRC32 CRC algorithms



	  Architecture: LoongArch with CRC32 instructions



endmenu

arch/loongarch/crypto/Makefile

+0 −2
Original line number Diff line number Diff line
@@ -2,5 +2,3 @@ 
#

# Makefile for LoongArch crypto files..

#
 


obj-$(CONFIG_CRYPTO_CRC32_LOONGARCH) += crc32-loongarch.o

arch/loongarch/crypto/crc32-loongarch.c

deleted100644 → 0
+0 −300
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * crc32.c - CRC32 and CRC32C using LoongArch crc* instructions

 *

 * Module based on mips/crypto/crc32-mips.c

 *

 * Copyright (C) 2014 Linaro Ltd <yazen.ghannam@linaro.org>

 * Copyright (C) 2018 MIPS Tech, LLC

 * Copyright (C) 2020-2023 Loongson Technology Corporation Limited

 */



#include <linux/module.h>

#include <crypto/internal/hash.h>



#include <asm/cpu-features.h>

#include <linux/unaligned.h>



#define _CRC32(crc, value, size, type)			\

do {							\

	__asm__ __volatile__(				\

		#type ".w." #size ".w" " %0, %1, %0\n\t"\

		: "+r" (crc)				\

		: "r" (value)				\

		: "memory");				\

} while (0)



#define CRC32(crc, value, size)		_CRC32(crc, value, size, crc)

#define CRC32C(crc, value, size)	_CRC32(crc, value, size, crcc)



static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)

{

	u32 crc = crc_;



	while (len >= sizeof(u64)) {

		u64 value = get_unaligned_le64(p);



		CRC32(crc, value, d);

		p += sizeof(u64);

		len -= sizeof(u64);

	}



	if (len & sizeof(u32)) {

		u32 value = get_unaligned_le32(p);



		CRC32(crc, value, w);

		p += sizeof(u32);

	}



	if (len & sizeof(u16)) {

		u16 value = get_unaligned_le16(p);



		CRC32(crc, value, h);

		p += sizeof(u16);

	}



	if (len & sizeof(u8)) {

		u8 value = *p++;



		CRC32(crc, value, b);

	}



	return crc;

}



static u32 crc32c_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)

{

	u32 crc = crc_;



	while (len >= sizeof(u64)) {

		u64 value = get_unaligned_le64(p);



		CRC32C(crc, value, d);

		p += sizeof(u64);

		len -= sizeof(u64);

	}



	if (len & sizeof(u32)) {

		u32 value = get_unaligned_le32(p);



		CRC32C(crc, value, w);

		p += sizeof(u32);

	}



	if (len & sizeof(u16)) {

		u16 value = get_unaligned_le16(p);



		CRC32C(crc, value, h);

		p += sizeof(u16);

	}



	if (len & sizeof(u8)) {

		u8 value = *p++;



		CRC32C(crc, value, b);

	}



	return crc;

}



#define CHKSUM_BLOCK_SIZE	1

#define CHKSUM_DIGEST_SIZE	4



struct chksum_ctx {

	u32 key;

};



struct chksum_desc_ctx {

	u32 crc;

};



static int chksum_init(struct shash_desc *desc)

{

	struct chksum_ctx *mctx = crypto_shash_ctx(desc->tfm);

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	ctx->crc = mctx->key;



	return 0;

}



/*

 * Setting the seed allows arbitrary accumulators and flexible XOR policy

 * If your algorithm starts with ~0, then XOR with ~0 before you set the seed.

 */

static int chksum_setkey(struct crypto_shash *tfm, const u8 *key, unsigned int keylen)

{

	struct chksum_ctx *mctx = crypto_shash_ctx(tfm);



	if (keylen != sizeof(mctx->key))

		return -EINVAL;



	mctx->key = get_unaligned_le32(key);



	return 0;

}



static int chksum_update(struct shash_desc *desc, const u8 *data, unsigned int length)

{

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	ctx->crc = crc32_loongarch_hw(ctx->crc, data, length);

	return 0;

}



static int chksumc_update(struct shash_desc *desc, const u8 *data, unsigned int length)

{

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	ctx->crc = crc32c_loongarch_hw(ctx->crc, data, length);

	return 0;

}



static int chksum_final(struct shash_desc *desc, u8 *out)

{

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	put_unaligned_le32(ctx->crc, out);

	return 0;

}



static int chksumc_final(struct shash_desc *desc, u8 *out)

{

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	put_unaligned_le32(~ctx->crc, out);

	return 0;

}



static int __chksum_finup(u32 crc, const u8 *data, unsigned int len, u8 *out)

{

	put_unaligned_le32(crc32_loongarch_hw(crc, data, len), out);

	return 0;

}



static int __chksumc_finup(u32 crc, const u8 *data, unsigned int len, u8 *out)

{

	put_unaligned_le32(~crc32c_loongarch_hw(crc, data, len), out);

	return 0;

}



static int chksum_finup(struct shash_desc *desc, const u8 *data, unsigned int len, u8 *out)

{

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	return __chksum_finup(ctx->crc, data, len, out);

}



static int chksumc_finup(struct shash_desc *desc, const u8 *data, unsigned int len, u8 *out)

{

	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);



	return __chksumc_finup(ctx->crc, data, len, out);

}



static int chksum_digest(struct shash_desc *desc, const u8 *data, unsigned int length, u8 *out)

{

	struct chksum_ctx *mctx = crypto_shash_ctx(desc->tfm);



	return __chksum_finup(mctx->key, data, length, out);

}



static int chksumc_digest(struct shash_desc *desc, const u8 *data, unsigned int length, u8 *out)

{

	struct chksum_ctx *mctx = crypto_shash_ctx(desc->tfm);



	return __chksumc_finup(mctx->key, data, length, out);

}



static int chksum_cra_init(struct crypto_tfm *tfm)

{

	struct chksum_ctx *mctx = crypto_tfm_ctx(tfm);



	mctx->key = 0;

	return 0;

}



static int chksumc_cra_init(struct crypto_tfm *tfm)

{

	struct chksum_ctx *mctx = crypto_tfm_ctx(tfm);



	mctx->key = ~0;

	return 0;

}



static struct shash_alg crc32_alg = {

	.digestsize		=	CHKSUM_DIGEST_SIZE,

	.setkey			=	chksum_setkey,

	.init			=	chksum_init,

	.update			=	chksum_update,

	.final			=	chksum_final,

	.finup			=	chksum_finup,

	.digest			=	chksum_digest,

	.descsize		=	sizeof(struct chksum_desc_ctx),

	.base			=	{

		.cra_name		=	"crc32",

		.cra_driver_name	=	"crc32-loongarch",

		.cra_priority		=	300,

		.cra_flags		=	CRYPTO_ALG_OPTIONAL_KEY,

		.cra_blocksize		=	CHKSUM_BLOCK_SIZE,

		.cra_ctxsize		=	sizeof(struct chksum_ctx),

		.cra_module		=	THIS_MODULE,

		.cra_init		=	chksum_cra_init,

	}

};



static struct shash_alg crc32c_alg = {

	.digestsize		=	CHKSUM_DIGEST_SIZE,

	.setkey			=	chksum_setkey,

	.init			=	chksum_init,

	.update			=	chksumc_update,

	.final			=	chksumc_final,

	.finup			=	chksumc_finup,

	.digest			=	chksumc_digest,

	.descsize		=	sizeof(struct chksum_desc_ctx),

	.base			=	{

		.cra_name		=	"crc32c",

		.cra_driver_name	=	"crc32c-loongarch",

		.cra_priority		=	300,

		.cra_flags		=	CRYPTO_ALG_OPTIONAL_KEY,

		.cra_blocksize		=	CHKSUM_BLOCK_SIZE,

		.cra_ctxsize		=	sizeof(struct chksum_ctx),

		.cra_module		=	THIS_MODULE,

		.cra_init		=	chksumc_cra_init,

	}

};



static int __init crc32_mod_init(void)

{

	int err;



	if (!cpu_has(CPU_FEATURE_CRC32))

		return 0;



	err = crypto_register_shash(&crc32_alg);

	if (err)

		return err;



	err = crypto_register_shash(&crc32c_alg);

	if (err)

		return err;



	return 0;

}



static void __exit crc32_mod_exit(void)

{

	if (!cpu_has(CPU_FEATURE_CRC32))

		return;



	crypto_unregister_shash(&crc32_alg);

	crypto_unregister_shash(&crc32c_alg);

}



module_init(crc32_mod_init);

module_exit(crc32_mod_exit);



MODULE_AUTHOR("Min Zhou <zhoumin@loongson.cn>");

MODULE_AUTHOR("Huacai Chen <chenhuacai@loongson.cn>");

MODULE_DESCRIPTION("CRC32 and CRC32C using LoongArch crc* instructions");

MODULE_LICENSE("GPL v2");