Commit 7334364f authored by Hector Martin's avatar Hector Martin Committed by Manivannan Sadhasivam
Browse files

PCI: apple: Use gpiod_set_value_cansleep in probe flow 



We're allowed to sleep here, so tell the GPIO core by using
gpiod_set_value_cansleep instead of gpiod_set_value.

Fixes: 1e33888f ("PCI: apple: Add initial hardware bring-up")
Signed-off-by: default avatarHector Martin <marcan@marcan.st>
Signed-off-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tested-by: default avatarJanne Grunau <j@jannau.net>
Reviewed-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://patch.msgid.link/20250401091713.2765724-12-maz@kernel.org
parent de9637c9

drivers/pci/controller/pcie-apple.c

+2 −2
Original line number Diff line number Diff line
@@ -562,7 +562,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, 
	rmw_set(PORT_APPCLK_EN, port->base + PORT_APPCLK);



	/* Assert PERST# before setting up the clock */

	gpiod_set_value(reset, 1);

	gpiod_set_value_cansleep(reset, 1);



	ret = apple_pcie_setup_refclk(pcie, port);

	if (ret < 0)
@@ -573,7 +573,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, 


	/* Deassert PERST# */

	rmw_set(PORT_PERST_OFF, port->base + PORT_PERST);

	gpiod_set_value(reset, 0);

	gpiod_set_value_cansleep(reset, 0);



	/* Wait for 100ms after PERST# deassertion (PCIe r5.0, 6.6.1) */

	msleep(100);