Commit 739214dd authored by Adam Ford's avatar Adam Ford Committed by Vinod Koul
Browse files

phy: freescale: fsl-samsung-hdmi: Fix 64-by-32 division cocci warnings 



The Kernel test robot returns the following warning:
 do_div() does a 64-by-32 division, please consider using div64_ul instead.

To prevent the 64-by-32 divsion, consolidate both the multiplication
and the do_div into one line which explicitly uses u64 sizes.

Fixes: 1951dbb4 ("phy: freescale: fsl-samsung-hdmi: Support dynamic integer")
Signed-off-by: default avatarAdam Ford <aford173@gmail.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412091243.fSObwwPi-lkp@intel.com/

Link: https://lore.kernel.org/r/20241215220555.99113-1-aford173@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent a2d633cb

drivers/phy/freescale/phy-fsl-samsung-hdmi.c

+1 −2
Original line number Diff line number Diff line
@@ -424,8 +424,7 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1 
			 * Fvco = (M * f_ref) / P,

			 * where f_ref is 24MHz.

			 */

			tmp = (u64)_m * 24 * MHZ;

			do_div(tmp, _p);

			tmp = div64_ul((u64)_m * 24 * MHZ, _p);

			if (tmp < 750 * MHZ ||

			    tmp > 3000 * MHZ)

				continue;