Commit a2d633cb authored by Zijun Hu's avatar Zijun Hu Committed by Vinod Koul
Browse files

phy: core: Fix an OF node refcount leakage in of_phy_provider_lookup()



For macro for_each_child_of_node(parent, child), refcount of @child has
been increased before entering its loop body, so normally needs to call
of_node_put(@child) before returning from the loop body to avoid refcount
leakage.

of_phy_provider_lookup() has such usage but does not call of_node_put()
before returning, so cause leakage of the OF node refcount.

Fix by simply calling of_node_put() before returning from the loop body.

The APIs affected by this issue are shown below since they indirectly
invoke problematic of_phy_provider_lookup().
phy_get()
of_phy_get()
devm_phy_get()
devm_of_phy_get()
devm_of_phy_get_by_index()

Fixes: 2a4c3701 ("phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-5-40ae28f5015a@quicinc.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5ebdc6be
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -145,9 +145,11 @@ static struct phy_provider *of_phy_provider_lookup(struct device_node *node)
			return phy_provider;

		for_each_child_of_node(phy_provider->children, child)
			if (child == node)
			if (child == node) {
				of_node_put(child);
				return phy_provider;
			}
	}

	return ERR_PTR(-EPROBE_DEFER);
}