Commit 75f26257 authored by Florian Fainelli's avatar Florian Fainelli Committed by Jakub Kicinski
Browse files

net: mdio: mdio-bcm-unimac: Refine incorrect clock message 



In light of a81649a4 ("net: mdio: mdio-bcm-unimac: Correct rate
fallback logic"), it became clear that the warning should be specific to
the MDIO controller instance, and there should be further information
provided to indicate what is wrong, whether the requested clock
frequency or the rate calculation. Clarify the message accordingly.

Signed-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250811165921.392030-1-florian.fainelli@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b3ba7d92

drivers/net/mdio/mdio-bcm-unimac.c

+3 −1
Original line number Diff line number Diff line
@@ -215,7 +215,9 @@ static int unimac_mdio_clk_set(struct unimac_mdio_priv *priv) 


	div = (rate / (2 * priv->clk_freq)) - 1;

	if (div & ~MDIO_CLK_DIV_MASK) {

		pr_warn("Incorrect MDIO clock frequency, ignoring\n");

		dev_warn(priv->mii_bus->parent,

			 "Ignoring MDIO clock frequency request: %d vs. rate: %ld\n",

			 priv->clk_freq, rate);

		ret = 0;

		goto out;

	}