Unverified Commit 79a45ddc authored by Mark Brown's avatar Mark Brown
Browse files

regulator: fixed: Rely on the core freeing the enable GPIO 



In order to simplify ownership rules for enable GPIOs supplied by drivers
regulator_register() always takes ownership of them, even if it ends up
failing for some other reason. We therefore should not free the GPIO if
registration fails but just let the core worry about things.

Fixes: 636f4618 (regulator: fixed: fix GPIO descriptor leak on register failure)
Reported-by: default avatarDiederik de Haas <diederik@cknow-tech.com>
Closes: https://lore.kernel.org/r/DEPEYUF5BRGY.UKFBWRRE8HNP@cknow-tech.com


Tested-by: default avatarDiederik de Haas <diederik@cknow-tech.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://patch.msgid.link/20251204-regulator-fixed-fix-gpiod-leak-v1-1-48efea5b82c2@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 84c8097e

drivers/regulator/fixed.c

+4 −7
Original line number Diff line number Diff line
@@ -330,13 +330,10 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) 


	drvdata->dev = devm_regulator_register(&pdev->dev, &drvdata->desc,

					       &cfg);

	if (IS_ERR(drvdata->dev)) {

		ret = dev_err_probe(&pdev->dev, PTR_ERR(drvdata->dev),

	if (IS_ERR(drvdata->dev))

		return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->dev),

				     "Failed to register regulator: %ld\n",

				     PTR_ERR(drvdata->dev));

		gpiod_put(cfg.ena_gpiod);

		return ret;

	}



	platform_set_drvdata(pdev, drvdata);