Unverified Commit 79ed408b authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mark Brown
Browse files

ASoC: mediatek: mt8188: avoid uninitialized variable use 



The 'msk' variable has no initialization:

sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: error: variable 'msk' is uninitialized when used here [-Werror,-Wuninitialized]
  311 |                         msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
      |                         ^~~

Set it to zero before the loop.

Fixes: c1e42ec0 ("ASoC: mediatek: mt8188: Add support for DMIC")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://patch.msgid.link/20250227131939.1040168-1-arnd@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a54a659f

sound/soc/mediatek/mt8188/mt8188-dai-dmic.c

+1 −0
Original line number Diff line number Diff line
@@ -307,6 +307,7 @@ static int mtk_dmic_event(struct snd_soc_dapm_widget *w, 
	switch (event) {

	case SND_SOC_DAPM_PRE_PMU:

		/* request fifo soft rst */

		msk = 0;

		for (i = dmic_num; i >= DMIC0; i--)

			msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);