Commit 7bb01e32 authored by Jouni Högander's avatar Jouni Högander
Browse files

drm/i915/display: Wait for vblank in case of PSR is using trans push 



In case PSR uses trans push as a "frame change" event and we need to wait
vblank after triggering PSR "frame change" event. Otherwise we may miss
selective updates.

DSB skips all waits while PSR is active. Check push send is skipped as well
because trans push send bit is not reset by the HW if VRR is not enabled ->
we may start configuring new selective update while previous is not
complete. Avoid this by waiting for vblank after sending trans push.

v2: some typos fixed

Signed-off-by: default avatarJouni Högander <jouni.hogander@intel.com>
Reviewed-by: default avatarAnkit Nautiyal <ankit.k.nautiyal@intel.com>
Link: https://patch.msgid.link/20260127124120.1069026-8-jouni.hogander@intel.com
parent f8c7baf8

drivers/gpu/drm/i915/display/intel_display.c

+19 −1
Original line number Diff line number Diff line
@@ -7390,9 +7390,27 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state, 
				new_crtc_state->dsb_color);



	if (new_crtc_state->use_dsb && !intel_color_uses_chained_dsb(new_crtc_state)) {

		/*

		 * Dsb wait vblank may or may not skip. Let's remove it for PSR

		 * trans push case to ensure we are not waiting two vblanks

		 */

		if (!intel_psr_use_trans_push(new_crtc_state))

			intel_dsb_wait_vblanks(new_crtc_state->dsb_commit, 1);



		intel_vrr_send_push(new_crtc_state->dsb_commit, new_crtc_state);



		/*

		 * In case PSR uses trans push as a "frame change" event and

		 * VRR is not in use we need to wait vblank. Otherwise we may

		 * miss selective updates. DSB skips all waits while PSR is

		 * active. Check push send is skipped as well because trans push

		 * send bit is not reset by the HW if VRR is not

		 * enabled -> we may start configuring new selective

		 * update while previous is not complete.

		 */

		if (intel_psr_use_trans_push(new_crtc_state))

			intel_dsb_wait_vblanks(new_crtc_state->dsb_commit, 1);



		intel_dsb_wait_for_delayed_vblank(state, new_crtc_state->dsb_commit);

		intel_vrr_check_push_sent(new_crtc_state->dsb_commit,

					  new_crtc_state);