Commit 7ed2d915 authored by Gianfranco Trad's avatar Gianfranco Trad Committed by Paolo Abeni
Browse files

qed: fix possible uninit pointer read in qed_mcp_nvm_info_populate() 

Coverity reports an uninit pointer read in qed_mcp_nvm_info_populate().
If EOPNOTSUPP is returned from qed_mcp_bist_nvm_get_num_images() ensure
nvm_info.num_images is set to 0 to avoid possible uninit assignment
to p_hwfn->nvm_info.image_att later on in out label.

Closes: https://scan5.scan.coverity.com/#/project-view/63204/10063?selectedIssue=1636666


Suggested-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarGianfranco Trad <gianf.trad@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241215011733.351325-2-gianf.trad@gmail.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 0cb2c504

drivers/net/ethernet/qlogic/qed/qed_mcp.c

+1 −0
Original line number Diff line number Diff line
@@ -3358,6 +3358,7 @@ int qed_mcp_nvm_info_populate(struct qed_hwfn *p_hwfn) 
					     p_ptt, &nvm_info.num_images);

	if (rc == -EOPNOTSUPP) {

		DP_INFO(p_hwfn, "DRV_MSG_CODE_BIST_TEST is not supported\n");

		nvm_info.num_images = 0;

		goto out;

	} else if (rc || !nvm_info.num_images) {

		DP_ERR(p_hwfn, "Failed getting number of images\n");