Commit 7fbbc086 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: omapfb/analog-tv: Don't put .remove() in .exit.text and drop suppress_bind_attrs 



On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv: section mismatch in reference: tvc_connector_driver+0x4 (section: .data) -> tvc_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 13c8fb98

drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c

+2 −3
Original line number Diff line number Diff line
@@ -221,7 +221,7 @@ static int tvc_probe(struct platform_device *pdev) 
	return r;

}



static int __exit tvc_remove(struct platform_device *pdev)

static int tvc_remove(struct platform_device *pdev)

{

	struct panel_drv_data *ddata = platform_get_drvdata(pdev);

	struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -247,11 +247,10 @@ MODULE_DEVICE_TABLE(of, tvc_of_match); 


static struct platform_driver tvc_connector_driver = {

	.probe	= tvc_probe,

	.remove	= __exit_p(tvc_remove),

	.remove	= tvc_remove,

	.driver	= {

		.name	= "connector-analog-tv",

		.of_match_table = tvc_of_match,

		.suppress_bind_attrs = true,

	},

};