Commit 81273eb8 authored by Harshitha Ramamurthy's avatar Harshitha Ramamurthy Committed by Jakub Kicinski
Browse files

gve: unlink old napi only if page pool exists 



Commit de70981f ("gve: unlink old napi when stopping a queue using
queue API") unlinks the old napi when stopping a queue. But this breaks
QPL mode of the driver which does not use page pool. Fix this by checking
that there's a page pool associated with the ring.

Cc: stable@vger.kernel.org
Fixes: de70981f ("gve: unlink old napi when stopping a queue using queue API")
Reviewed-by: default avatarJoshua Washington <joshwash@google.com>
Signed-off-by: default avatarHarshitha Ramamurthy <hramamurthy@google.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250317214141.286854-1-hramamurthy@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c60d101a

drivers/net/ethernet/google/gve/gve_rx_dqo.c

+2 −1
Original line number Diff line number Diff line
@@ -114,6 +114,7 @@ void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx) 
	if (!gve_rx_was_added_to_block(priv, idx))

		return;



	if (rx->dqo.page_pool)

		page_pool_disable_direct_recycling(rx->dqo.page_pool);

	gve_remove_napi(priv, ntfy_idx);

	gve_rx_remove_from_block(priv, idx);