Commit 8179041f authored by Li Zhijian's avatar Li Zhijian Committed by Martin K. Petersen
Browse files

scsi: pm8001: Convert snprintf() to sysfs_emit() 



Per filesystems/sysfs.rst, show() should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

> ./drivers/scsi/pm8001/pm8001_ctl.c:883:8-16: WARNING: please use sysfs_emit

No functional change intended

CC: Jack Wang <jinpu.wang@cloud.ionos.com>
CC: James E.J. Bottomley <jejb@linux.ibm.com>
CC: Martin K. Petersen <martin.petersen@oracle.com>
CC: linux-scsi@vger.kernel.org
Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Link: https://lore.kernel.org/r/20240116045151.3940401-32-lizhijian@fujitsu.com


Acked-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5fbf37e5

drivers/scsi/pm8001/pm8001_ctl.c

+3 −3
Original line number Diff line number Diff line
@@ -880,7 +880,7 @@ static ssize_t pm8001_show_update_fw(struct device *cdev, 
	if (pm8001_ha->fw_status != FLASH_IN_PROGRESS)

		pm8001_ha->fw_status = FLASH_OK;



	return snprintf(buf, PAGE_SIZE, "status=%x %s\n",

	return sysfs_emit(buf, "status=%x %s\n",

			  flash_error_table[i].err_code,

			  flash_error_table[i].reason);

}