Unverified Commit 83ba6efa authored by Mark Brown's avatar Mark Brown
Browse files

spi: rockchip: Use plain request_irq() 



The Rockchip driver has since interrupt support was added used
request_threaded_irq() but not actually supplied a threaded handler,
handling everything in the primary handler.  This is equivalent to just
using a plain request_irq(), and since aef30c8d (genirq: Warn about
using IRQF_ONESHOT without a threaded handler) the current behaviour has
triggered a WARN_ON().  Convert to use request_irq().

Reported-by: default avatarAishwarya TCV <Aishwarya.TCV@arm.com>
Reviewed-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://patch.msgid.link/20260116-spi-rockchip-threaded-irq-v1-1-c45c3a5a38b1@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0f93dddb

drivers/spi/spi-rockchip.c

+2 −2
Original line number Diff line number Diff line
@@ -805,8 +805,8 @@ static int rockchip_spi_probe(struct platform_device *pdev) 
	if (ret < 0)

		goto err_put_ctlr;



	ret = devm_request_threaded_irq(&pdev->dev, ret, rockchip_spi_isr, NULL,

					IRQF_ONESHOT, dev_name(&pdev->dev), ctlr);

	ret = devm_request_irq(&pdev->dev, ret, rockchip_spi_isr, 0,

			       dev_name(&pdev->dev), ctlr);

	if (ret)

		goto err_put_ctlr;