Commit 8548c84c authored by Sathesh B Edara's avatar Sathesh B Edara Committed by Jakub Kicinski
Browse files

octeon_ep_vf: Resolve netdevice usage count issue 



The netdevice usage count increases during transmit queue timeouts
because netdev_hold is called in ndo_tx_timeout, scheduling a task
to reinitialize the card. Although netdev_put is called at the end
of the scheduled work, rtnl_unlock checks the reference count during
cleanup. This could cause issues if transmit timeout is called on
multiple queues.

Fixes: cb7dd712 ("octeon_ep_vf: Add driver framework and device initialization")
Signed-off-by: default avatarSathesh B Edara <sedara@marvell.com>
Link: https://patch.msgid.link/20250424133944.28128-1-sedara@marvell.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 765f253e

drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c

+3 −1
Original line number Diff line number Diff line
@@ -835,7 +835,9 @@ static void octep_vf_tx_timeout(struct net_device *netdev, unsigned int txqueue) 
	struct octep_vf_device *oct = netdev_priv(netdev);



	netdev_hold(netdev, NULL, GFP_ATOMIC);

	schedule_work(&oct->tx_timeout_task);

	if (!schedule_work(&oct->tx_timeout_task))

		netdev_put(netdev, NULL);



}



static int octep_vf_set_mac(struct net_device *netdev, void *p)