Commit 85e444a6 authored by Abel Vesa's avatar Abel Vesa Committed by Neil Armstrong
Browse files

drm/bridge: Fix assignment of the of_node of the parent to aux bridge 



The assignment of the of_node to the aux bridge needs to mark the
of_node as reused as well, otherwise resource providers like pinctrl will
report a gpio as already requested by a different device when both pinconf
and gpios property are present.
Fix that by using the device_set_of_node_from_dev() helper instead.

Fixes: 6914968a ("drm/bridge: properly refcount DT nodes in aux bridge drivers")
Cc: stable@vger.kernel.org      # 6.8
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarAbel Vesa <abel.vesa@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org
parent 83f00078

drivers/gpu/drm/bridge/aux-bridge.c

+2 −1
Original line number Diff line number Diff line
@@ -58,9 +58,10 @@ int drm_aux_bridge_register(struct device *parent) 
	adev->id = ret;

	adev->name = "aux_bridge";

	adev->dev.parent = parent;

	adev->dev.of_node = of_node_get(parent->of_node);

	adev->dev.release = drm_aux_bridge_release;



	device_set_of_node_from_dev(&adev->dev, parent);



	ret = auxiliary_device_init(adev);

	if (ret) {

		ida_free(&drm_aux_bridge_ida, adev->id);