Commit 88c23a32 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Keith Busch
Browse files

nvme-fabrics: handle zero MAXCMD without closing the connection 



The NVMe specification states that MAXCMD is mandatory
for NVMe-over-Fabrics implementations. However, some NVMe/TCP
and NVMe/FC arrays from major vendors have buggy firmware
that reports MAXCMD as zero in the Identify Controller data structure.

Currently, the implementation closes the connection in such cases,
completely preventing the host from connecting to the target.

Fix the issue by printing a clear error message about the firmware bug
and allowing the connection to proceed. It assumes that the
target supports a MAXCMD value of SQSIZE + 1. If any issues arise,
the user can manually adjust SQSIZE to mitigate them.

Fixes: 49995681 ("nvme-fabrics: check max outstanding commands")
Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Reviewed-by: default avatarLaurence Oberman <loberman@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent b0de5456

drivers/nvme/host/core.c

+3 −2
Original line number Diff line number Diff line
@@ -3233,8 +3233,9 @@ static int nvme_check_ctrl_fabric_info(struct nvme_ctrl *ctrl, struct nvme_id_ct 
	}



	if (!ctrl->maxcmd) {

		dev_err(ctrl->device, "Maximum outstanding commands is 0\n");

		return -EINVAL;

		dev_warn(ctrl->device,

			"Firmware bug: maximum outstanding commands is 0\n");

		ctrl->maxcmd = ctrl->sqsize + 1;

	}



	return 0;