Commit 898918d6 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Jonathan Cameron
Browse files

iio: imu: bno055: constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20241215-sysfs-const-bin_attr-iio-v1-1-a5801212482e@weissschuh.net


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 9351bbb1

drivers/iio/imu/bno055/bno055.c

+4 −4
Original line number Diff line number Diff line
@@ -1193,7 +1193,7 @@ static ssize_t serialnumber_show(struct device *dev, 
}



static ssize_t calibration_data_read(struct file *filp, struct kobject *kobj,

				     struct bin_attribute *bin_attr, char *buf,

				     const struct bin_attribute *bin_attr, char *buf,

				     loff_t pos, size_t count)

{

	struct bno055_priv *priv = iio_priv(dev_to_iio_dev(kobj_to_dev(kobj)));
@@ -1348,16 +1348,16 @@ static struct attribute *bno055_attrs[] = { 
	NULL

};



static BIN_ATTR_RO(calibration_data, BNO055_CALDATA_LEN);

static const BIN_ATTR_RO(calibration_data, BNO055_CALDATA_LEN);



static struct bin_attribute *bno055_bin_attrs[] = {

static const struct bin_attribute *const bno055_bin_attrs[] = {

	&bin_attr_calibration_data,

	NULL

};



static const struct attribute_group bno055_attrs_group = {

	.attrs = bno055_attrs,

	.bin_attrs = bno055_bin_attrs,

	.bin_attrs_new = bno055_bin_attrs,

};



static const struct iio_info bno055_info = {