Commit 8b9c6ab1 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

usb: typec: intel_pmc_mux: Deduplicate ACPI matching in probe 



There is no need to call acpi_dev_present() followed by
acpi_dev_get_first_match_dev() as they both do the same
with only difference in the returning value. Instead,
call the latter and check its result.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230102202933.15968-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c3194949

drivers/usb/typec/mux/intel_pmc_mux.c

+4 −5
Original line number Diff line number Diff line
@@ -602,16 +602,15 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) 
	int ret;



	for (dev_id = &iom_acpi_ids[0]; dev_id->id[0]; dev_id++) {

		if (acpi_dev_present(dev_id->id, NULL, -1)) {

			pmc->iom_port_status_offset = (u32)dev_id->driver_data;

		adev = acpi_dev_get_first_match_dev(dev_id->id, NULL, -1);

		if (adev)

			break;

	}

	}



	if (!adev)

		return -ENODEV;



	pmc->iom_port_status_offset = (u32)dev_id->driver_data;



	INIT_LIST_HEAD(&resource_list);

	ret = acpi_dev_get_memory_resources(adev, &resource_list);

	if (ret < 0) {