Unverified Commit 8c30a734 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Christian Brauner
Browse files

coda: Convert coda_symlink_filler() to use folio_end_read() 



This is slightly more efficient than separate calls to
folio_mark_uptodate() and folio_unlock(), and it's easier to read.
Get rid of the call to folio_set_error() as nobody will check this flag.

Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: coda@cs.cmu.edu
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Link: https://lore.kernel.org/r/20240530202110.2653630-3-willy@infradead.org


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 263cf578

fs/coda/symlink.c

+1 −9
Original line number Diff line number Diff line
@@ -31,15 +31,7 @@ static int coda_symlink_filler(struct file *file, struct folio *folio) 
	cii = ITOC(inode);



	error = venus_readlink(inode->i_sb, &cii->c_fid, p, &len);

	if (error)

		goto fail;

	folio_mark_uptodate(folio);

	folio_unlock(folio);

	return 0;



fail:

	folio_set_error(folio);

	folio_unlock(folio);

	folio_end_read(folio, error == 0);

	return error;

}