Commit 8ca9590c authored by Yemike Abhilash Chandra's avatar Yemike Abhilash Chandra Committed by Vinod Koul
Browse files

dmaengine: ti: k3-udma: Use cap_mask directly from dma_device structure instead of a local copy 



Currently, a local dma_cap_mask_t variable is used to store device
cap_mask within udma_of_xlate(). However, the DMA_PRIVATE flag in
the device cap_mask can get cleared when the last channel is released.
This can happen right after storing the cap_mask locally in
udma_of_xlate(), and subsequent dma_request_channel() can fail due to
mismatch in the cap_mask. Fix this by removing the local dma_cap_mask_t
variable and directly using the one from the dma_device structure.

Fixes: 25dcb5dd ("dmaengine: ti: New driver for K3 UDMA")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarVaishnav Achath <vaishnav.a@ti.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Reviewed-by: default avatarUdit Kumar <u-kumar1@ti.com>
Signed-off-by: default avatarYemike Abhilash Chandra <y-abhilashchandra@ti.com>
Link: https://lore.kernel.org/r/20250417075521.623651-1-y-abhilashchandra@ti.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent df180e65

drivers/dma/ti/k3-udma.c

+1 −2
Original line number Diff line number Diff line
@@ -4246,7 +4246,6 @@ static struct dma_chan *udma_of_xlate(struct of_phandle_args *dma_spec, 
				      struct of_dma *ofdma)

{

	struct udma_dev *ud = ofdma->of_dma_data;

	dma_cap_mask_t mask = ud->ddev.cap_mask;

	struct udma_filter_param filter_param;

	struct dma_chan *chan;
@@ -4278,7 +4277,7 @@ static struct dma_chan *udma_of_xlate(struct of_phandle_args *dma_spec, 
		}

	}



	chan = __dma_request_channel(&mask, udma_dma_filter_fn, &filter_param,

	chan = __dma_request_channel(&ud->ddev.cap_mask, udma_dma_filter_fn, &filter_param,

				     ofdma->of_node);

	if (!chan) {

		dev_err(ud->dev, "get channel fail in %s.\n", __func__);