Commit 8ef631e9 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jakub Kicinski
Browse files

net: sparx5: flower: check for unsupported control flags 



Use flow_rule_is_supp_control_flags() to reject filters with
unsupported control flags.

In case any unsupported control flags are masked,
flow_rule_is_supp_control_flags() sets a NL extended
error message, and we return -EOPNOTSUPP.

Only compile-tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Tested-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Link: https://lore.kernel.org/r/20240424121632.459022-5-ast@fiberby.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b92eb1ac

drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c

+5 −0
Original line number Diff line number Diff line
@@ -197,6 +197,11 @@ sparx5_tc_flower_handler_control_usage(struct vcap_tc_flower_parse_usage *st) 
		}

	}



	if (!flow_rule_is_supp_control_flags(FLOW_DIS_IS_FRAGMENT |

					     FLOW_DIS_FIRST_FRAG,

					     mt.mask->flags, extack))

		return -EOPNOTSUPP;



	st->used_keys |= BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL);



	return err;