Commit 90154d08 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

misc: ds1682: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-9-ba5e79fe8771@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 052bd11e

drivers/misc/ds1682.c

+4 −4
Original line number Diff line number Diff line
@@ -154,7 +154,7 @@ static const struct attribute_group ds1682_group = { 
 * User data attribute

 */

static ssize_t ds1682_eeprom_read(struct file *filp, struct kobject *kobj,

				  struct bin_attribute *attr,

				  const struct bin_attribute *attr,

				  char *buf, loff_t off, size_t count)

{

	struct i2c_client *client = kobj_to_i2c_client(kobj);
@@ -172,7 +172,7 @@ static ssize_t ds1682_eeprom_read(struct file *filp, struct kobject *kobj, 
}



static ssize_t ds1682_eeprom_write(struct file *filp, struct kobject *kobj,

				   struct bin_attribute *attr,

				   const struct bin_attribute *attr,

				   char *buf, loff_t off, size_t count)

{

	struct i2c_client *client = kobj_to_i2c_client(kobj);
@@ -194,8 +194,8 @@ static const struct bin_attribute ds1682_eeprom_attr = { 
		.mode = S_IRUGO | S_IWUSR,

	},

	.size = DS1682_EEPROM_SIZE,

	.read = ds1682_eeprom_read,

	.write = ds1682_eeprom_write,

	.read_new = ds1682_eeprom_read,

	.write_new = ds1682_eeprom_write,

};



static int ds1682_nvmem_read(void *priv, unsigned int offset, void *val,