Commit 915c3061 authored by Ruben Wauters's avatar Ruben Wauters Committed by Thomas Zimmermann
Browse files

drm/gud: fix accidentally deleted IS_ERR() check 



During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in
commit 2d2f1dc7 ("drm: gud: replace WARN_ON/WARN_ON_ONCE with
drm versions"), the IS_ERR check was accidentally removed, breaking
the gud_connector_add_properties() function, as any valid pointer
in state_val would produce an error.

The warning was reported by kernel test robot, and is fixed in this patch.

Fixes: 2d2f1dc7 ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/


Signed-off-by: default avatarRuben Wauters <rubenru09@aol.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250922173836.5608-1-rubenru09@aol.com
parent 3a9cf301

drivers/gpu/drm/gud/gud_connector.c

+1 −1
Original line number Diff line number Diff line
@@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct drm_connector_state *connector_state, 
			unsigned int *state_val;



			state_val = gud_connector_tv_state_val(prop, &connector_state->tv);

			if (drm_WARN_ON_ONCE(connector_state->connector->dev, state_val))

			if (drm_WARN_ON_ONCE(connector_state->connector->dev, IS_ERR(state_val)))

				return PTR_ERR(state_val);



			val = *state_val;