Commit 93598167 authored by Miri Korenblit's avatar Miri Korenblit
Browse files

wifi: iwlwifi: mvm: assume '1' as the default mac_config_cmd version 



Unfortunately, FWs of some devices don't have the version of the
iwl_mac_config_cmd defined in the TLVs. We send 0 as the 'def argument
to  iwl_fw_lookup_cmd_ver, so for such FWs, the return value will be 0,
leading to a warning, and to not sending the command.

Fix this by assuming that the default version is 1.

Fixes: 83f3ac28 ("wifi: iwlwifi: Fix incorrect logic on cmd_ver range checking")
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250624071427.2662621-1-miriam.rachel.korenblit@intel.com
parent 5c8013ae

drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c

+2 −2
Original line number Diff line number Diff line
@@ -32,9 +32,9 @@ static void iwl_mvm_mld_mac_ctxt_cmd_common(struct iwl_mvm *mvm, 
	unsigned int link_id;

	int cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw,

					    WIDE_ID(MAC_CONF_GROUP,

						    MAC_CONFIG_CMD), 0);

						    MAC_CONFIG_CMD), 1);



	if (WARN_ON(cmd_ver < 1 || cmd_ver > 3))

	if (WARN_ON(cmd_ver > 3))

		return;



	cmd->id_and_color = cpu_to_le32(mvmvif->id);