Commit 9a8385fe authored by Arkadiusz Kubalewski's avatar Arkadiusz Kubalewski Committed by Tony Nguyen
Browse files

ice: fix dpll periodic work data updates on PF reset 



Do not allow dpll periodic work function to acquire data from firmware
if PF reset is in progress. Acquiring data will cause dmesg errors as the
firmware cannot respond or process the request properly during the reset
time.

Test by looping execution of below step until dmesg error appears:
- perform PF reset
$ echo 1 > /sys/class/net/<ice PF>/device/reset

Fixes: d7999f5e ("ice: implement dpll interface to control cgu")
Reviewed-by: default avatarIgor Bagnucki <igor.bagnucki@intel.com>
Signed-off-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent fc7fd1a1

drivers/net/ethernet/intel/ice/ice_dpll.c

+4 −1
Original line number Diff line number Diff line
@@ -1364,8 +1364,10 @@ static void ice_dpll_periodic_work(struct kthread_work *work) 
	struct ice_pf *pf = container_of(d, struct ice_pf, dplls);

	struct ice_dpll *de = &pf->dplls.eec;

	struct ice_dpll *dp = &pf->dplls.pps;

	int ret;

	int ret = 0;



	if (ice_is_reset_in_progress(pf->state))

		goto resched;

	mutex_lock(&pf->dplls.lock);

	ret = ice_dpll_update_state(pf, de, false);

	if (!ret)
@@ -1385,6 +1387,7 @@ static void ice_dpll_periodic_work(struct kthread_work *work) 
	ice_dpll_notify_changes(de);

	ice_dpll_notify_changes(dp);



resched:

	/* Run twice a second or reschedule if update failed */

	kthread_queue_delayed_work(d->kworker, &d->work,

				   ret ? msecs_to_jiffies(10) :