Commit 9af152dc authored by Ivan Abramov's avatar Ivan Abramov Committed by Patrik Jakobsson
Browse files

drm/gma500: Add NULL check for pci_gfx_root in mid_get_vbt_data() 



Since pci_get_domain_bus_and_slot() can return NULL, add NULL check for
pci_gfx_root in the mid_get_vbt_data().

This change is similar to the checks implemented in mid_get_fuse_settings()
and mid_get_pci_revID(), which were introduced by commit 0cecdd81
("gma500: Final enables for Oaktrail") as "additional minor
bulletproofing".

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: f910b411 ("gma500: Add the glue to the various BIOS and firmware interfaces")
Signed-off-by: default avatarIvan Abramov <i.abramov@mt-integration.ru>
Signed-off-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250306112046.17144-1-i.abramov@mt-integration.ru
parent 80da96d7

drivers/gpu/drm/gma500/mid_bios.c

+5 −0
Original line number Diff line number Diff line
@@ -279,6 +279,11 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv) 
					    0, PCI_DEVFN(2, 0));

	int ret = -1;



	if (pci_gfx_root == NULL) {

		WARN_ON(1);

		return;

	}



	/* Get the address of the platform config vbt */

	pci_read_config_dword(pci_gfx_root, 0xFC, &addr);

	pci_dev_put(pci_gfx_root);