Commit 9b0f5109 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

lan78xx: remove redundant statement in lan78xx_get_eee 



eee_active is set by phy_ethtool_get_eee() already, using the same
logic plus an additional check against link speed/duplex values.
See genphy_c45_eee_is_active() for details.
So we can remove this line.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/b086b296-0a1b-42d4-8e2b-ef6682598185@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5733d139

drivers/net/usb/lan78xx.c

+0 −2
Original line number Diff line number Diff line
@@ -1691,8 +1691,6 @@ static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata) 
	ret = lan78xx_read_reg(dev, MAC_CR, &buf);

	if (buf & MAC_CR_EEE_EN_) {

		edata->eee_enabled = true;

		edata->eee_active = !!(edata->advertised &

				       edata->lp_advertised);

		edata->tx_lpi_enabled = true;

		/* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */

		ret = lan78xx_read_reg(dev, EEE_TX_LPI_REQ_DLY, &buf);