Commit a05543d6 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: it87: balance superio enter/exit calls in error path 



We always call superio_enter() in it87_gpio_direction_out() but only
call superio_exit() if the call to it87_gpio_set() succeeds. Move the
label to balance the calls in error path as well.

Fixes: ef877a15 ("gpio: it87: use new line value setter callbacks")
Reported-by: default avatarDaniel Gibson <daniel@gibson.sh>
Closes: https://lore.kernel.org/all/bd0a00e3-9b8c-43e8-8772-e67b91f4c71e@gibson.sh/
Link: https://lore.kernel.org/r/20251210055026.23146-1-bartosz.golaszewski@oss.qualcomm.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent 8f0b4cce

drivers/gpio/gpio-it87.c

+3 −8
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 


#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt



#include <linux/cleanup.h>

#include <linux/init.h>

#include <linux/kernel.h>

#include <linux/module.h>
@@ -241,23 +242,17 @@ static int it87_gpio_direction_out(struct gpio_chip *chip, 
	mask = 1 << (gpio_num % 8);

	group = (gpio_num / 8);



	spin_lock(&it87_gpio->lock);

	guard(spinlock)(&it87_gpio->lock);



	rc = superio_enter();

	if (rc)

		goto exit;

		return rc;



	/* set the output enable bit */

	superio_set_mask(mask, group + it87_gpio->output_base);



	rc = it87_gpio_set(chip, gpio_num, val);

	if (rc)

		goto exit;



	superio_exit();



exit:

	spin_unlock(&it87_gpio->lock);

	return rc;

}